Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pickling for vocabulary #2391

Merged
merged 2 commits into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@joelgrus
Copy link
Contributor

joelgrus commented Jan 18, 2019

fixes #2389

@joelgrus joelgrus requested a review from DeNeutoy Jan 18, 2019

@DeNeutoy
Copy link
Contributor

DeNeutoy left a comment

LGTM

@joelgrus joelgrus merged commit 174f539 into allenai:master Jan 18, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 92% (+<1%) compared to 2d29736
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.