Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing requirement to setup.py #2564

Merged
merged 1 commit into from Mar 2, 2019

Conversation

@matt-gardner
Copy link
Member

commented Mar 2, 2019

I figured out why the master commit was breaking - I added something to requirements.txt without adding a corresponding entry to setup.py. I forgot that we had to do this. I thought we had some check that made sure these were consistent? Did that not actually happen? Anyway, I'm going to merge this when tests pass, so I can get a demo deploy set up.

@matt-gardner matt-gardner merged commit 31af01e into allenai:master Mar 2, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing c54fcc6...108819b
Details
codecov/project 92% remains the same compared to c54fcc6
Details

@matt-gardner matt-gardner deleted the matt-gardner:fix_setup branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.