Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextClassificationJsonReader handling of unlabeled instances #2621

Merged

Conversation

@nelson-liu
Copy link
Member

nelson-liu commented Mar 18, 2019

ended up running into this myself, so this fixes #2619
This fix is required to use the dataset reader while predicting on unlabeled text.
Also adds a small doc fix.

nelson-liu added 2 commits Mar 18, 2019
@nelson-liu nelson-liu requested a review from kernelmachine Mar 18, 2019
@matt-gardner

This comment has been minimized.

Copy link
Member

matt-gardner commented Mar 18, 2019

@nelson-liu, don't worry too much about merging into master all the time. If you know that what you're doing doesn't conflict with other open PRs, it's not a big deal, and we can just override that check when merging.

@nelson-liu

This comment has been minimized.

Copy link
Member Author

nelson-liu commented Mar 18, 2019

ok, thanks @matt-gardner !

Copy link
Contributor

kernelmachine left a comment

LGTM!

@nelson-liu

This comment has been minimized.

Copy link
Member Author

nelson-liu commented Mar 18, 2019

@matt-gardner want to override the "out-of-date with the base branch" check? I don't have the privileges.

@matt-gardner matt-gardner merged commit 9e72ee0 into allenai:master Mar 18, 2019
3 checks passed
3 checks passed
Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 92% (+<1%) compared to fe80f9f
Details
reiyw added a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
…enai#2621)

* Fix docstring to accurately reflect input expectations

* Fix TextClassificationJson reader handling of unlabeled data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.