Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NAQANET training config and fixing test format in evaluation #2695

Merged
merged 7 commits into from Apr 6, 2019

Conversation

@dDua
Copy link
Contributor

dDua commented Apr 5, 2019

No description provided.

Copy link
Member

matt-gardner left a comment

Thanks @dDua!

@matt-gardner matt-gardner merged commit 73bc049 into allenai:master Apr 6, 2019
3 checks passed
3 checks passed
Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 95% of diff hit (target 90%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +3% compared to e5adfd7
Details
reiyw added a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
…llenai#2695)

* bug fixes in drop evaluation and adding more tests

* fixing comment

* resolved review comments and added failure test for answer

* fixing the style error

* adding naqanet config and fixing drop test format

* fixing config failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.