Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring for `BasicClassifier` incorrectly states that `Seq2VecEncoder` is optional. #2712

Merged
merged 1 commit into from Apr 15, 2019

Conversation

@sethah
Copy link
Contributor

commented Apr 13, 2019

I believe this got changed during the PR process and the docstring never got updated. Seq2VecEncoder is not an optional argument.

@matt-gardner
Copy link
Member

left a comment

Thanks!

@matt-gardner matt-gardner merged commit 58f386c into allenai:master Apr 15, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 74634e3...dca2a5a
Details
codecov/project 92% remains the same compared to 74634e3
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.