Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on ELMo NER model to match current configuration #2761

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@luckytoilet
Copy link
Contributor

commented Apr 26, 2019

Fixes mismatch between code and comments, where attempting to run the pretrained NER model gives the following error:

allennlp.common.checks.ConfigurationError: "Extra parameters passed to CrfTagger: {'constraint_type': 'BIOUL'}"

@luckytoilet luckytoilet changed the title Update model comment to match current configuration Update comment on ELMo NER model to match current configuration Apr 26, 2019

@DeNeutoy
Copy link
Contributor

left a comment

LGTM, thanks!

@DeNeutoy DeNeutoy merged commit c6ddb9d into allenai:master Apr 26, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 979817d...6df5ce9
Details
codecov/project 92% remains the same compared to 979817d
Details
scarecrow1123 added a commit to scarecrow1123/allennlp that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.