Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auc.py #2775

Merged
merged 7 commits into from May 16, 2019

Conversation

@guoquan
Copy link
Contributor

commented Apr 29, 2019

To allow, in some case, there is no positive or negative sample in a batch.

Update auc.py
To allow, in some case, there is no positive or negative sample in a batch.
@joelgrus
Copy link
Contributor

left a comment

I don't think this check does what you think it does

In [16]: [1] <= [0, 1]                                                         
Out[16]: False
@guoquan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

I don't think this check does what you think it does

In [16]: [1] <= [0, 1]                                                         
Out[16]: False

Oh sorry for that. I meant to have set([1]) <= set([0, 1]).
Updated.

guoquan added 4 commits Apr 29, 2019
@guoquan

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Hi, sorry for disturbing but how can I improve the PR now?

Update auc.py
Not sure should it be more efficient leaving `torch.unique` at line #50 there or not.
@Varal7 Varal7 referenced this pull request May 7, 2019
@guoquan

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Hi, is this resolved, until 839503a?

@joelgrus joelgrus merged commit c59a3a8 into allenai:master May 16, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 92% (+0%) compared to 7bdd575
Details
@joelgrus

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

there you go, sorry it slipped it through the cracks

scarecrow1123 added a commit to scarecrow1123/allennlp that referenced this pull request Aug 8, 2019
Update auc.py (allenai#2775)
* Update auc.py

To allow, in some case, there is no positive or negative sample in a batch.

* Update auc.py

* Update auc.py

Not sure should it be more efficient leaving `torch.unique` at line allenai#50 there or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.