Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency conflicts (by removing moto + disabled tests that use it) #2902

Merged
merged 2 commits into from May 29, 2019

Conversation

@joelgrus
Copy link
Contributor

commented May 29, 2019

fixes #2901

they were all caused by moto, the mock s3 library, which was used in a few of our tests; HOWEVER, those tests have all been disabled for many months, as the library broke. When I installed the latest version and enabled the tests, one was still broken, for reasons that were not obvious.

Anyway, given that we don't run these tests anyway, the simplest way to fix the dependency conflict is by getting rid of the tests and getting rid of the dependency.

@joelgrus joelgrus requested a review from schmmd May 29, 2019

@schmmd
schmmd approved these changes May 29, 2019
Copy link
Member

left a comment

This PR is a step forward because it fixes a real problem without any other affects on our running code. If someone identifies these tests as critical, they can be added back in a future PR from the revision history.

@DeNeutoy

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

+1 i'm pretty sure this was used for something pretty niche anyway

@joelgrus joelgrus merged commit 26ac349 into allenai:master May 29, 2019

3 checks passed

Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 69c1c9f...36c3dc2
Details
codecov/project 92% remains the same compared to 69c1c9f
Details
scarecrow1123 added a commit to scarecrow1123/allennlp that referenced this pull request Aug 8, 2019
fix dependency conflicts (by removing moto + disabled tests that use …
…it) (allenai#2902)

* reinstate + fix moto tests

* remove moto and its tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.