Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unidecode as it's GPLv2 and isn't in requirements.txt. #3543

Merged
merged 2 commits into from Dec 19, 2019
Merged

Conversation

@schmmd
Copy link
Member

schmmd commented Dec 18, 2019

No description provided.

@schmmd

This comment has been minimized.

Copy link
Member Author

schmmd commented Dec 18, 2019

@schmmd

This comment has been minimized.

Copy link
Member Author

schmmd commented Dec 18, 2019

unidecode was introduced in 121d3e8 and was part of the Java semantic parsing code that no longer exists.

@schmmd schmmd requested review from DeNeutoy and matt-gardner Dec 18, 2019
@dirkgr
dirkgr approved these changes Dec 19, 2019
Copy link
Member

dirkgr left a comment

♟️

@schmmd schmmd merged commit b5d153b into master Dec 19, 2019
3 checks passed
3 checks passed
Pull Requests (AllenNLP Library) TeamCity build finished
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
@schmmd schmmd deleted the rm-unidecode branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.