From 09b79927a592c9974ff33bae19c2ade0c403fb6d Mon Sep 17 00:00:00 2001 From: Sawit Trisirisatayawong Date: Tue, 24 Jan 2023 12:29:02 +0700 Subject: [PATCH 1/4] fix(components): fix unknown code upload block height --- src/lib/pages/code-details/components/CodeInfoSection.tsx | 4 +++- src/lib/services/codeService.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/pages/code-details/components/CodeInfoSection.tsx b/src/lib/pages/code-details/components/CodeInfoSection.tsx index 1b25bec04..69e144d35 100644 --- a/src/lib/pages/code-details/components/CodeInfoSection.tsx +++ b/src/lib/pages/code-details/components/CodeInfoSection.tsx @@ -28,7 +28,7 @@ const getMethodSpecificRender = ( /> ), - storedBlockRender: ( + storedBlockRender: codeProposalInfo.height ? ( <> + ) : ( + N/A ), }; } diff --git a/src/lib/services/codeService.ts b/src/lib/services/codeService.ts index fa7c49ba7..3fefa6be2 100644 --- a/src/lib/services/codeService.ts +++ b/src/lib/services/codeService.ts @@ -133,7 +133,7 @@ export const useCodeInfoByCodeId = ( proposal: codes_by_pk.code_proposals[0] ? { proposalId: codes_by_pk.code_proposals[0].proposal_id, - height: codes_by_pk.code_proposals[0].block?.height ?? 0, + height: codes_by_pk.code_proposals[0].block?.height, created: parseDateDefault( codes_by_pk.code_proposals[0].block?.timestamp ), From 0b9714576e0dfebe8de4e3c73b87193ac84ac083 Mon Sep 17 00:00:00 2001 From: Sawit Trisirisatayawong Date: Tue, 24 Jan 2023 13:07:02 +0700 Subject: [PATCH 2/4] docs: update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ebb5b5766..2ab2723f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased ### Features + +- [122](https://github.com/alleslabs/celatone-frontend/pull/122) Fix unknown code upload block height - [#121](https://github.com/alleslabs/celatone-frontend/pull/121) Fix code snippet for query axios - [#76](https://github.com/alleslabs/celatone-frontend/pull/76) Add Public projects page - [#116](https://github.com/alleslabs/celatone-frontend/pull/116) Support Terra2.0 mainnet and testnet From ece8c18cd054bbc5504433ed5a8fe726de57dbea Mon Sep 17 00:00:00 2001 From: Songwong Tasneeyapant <16089160+songwongtp@users.noreply.github.com> Date: Tue, 24 Jan 2023 18:16:33 +0700 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2ab2723f3..1c0a978de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,7 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Features -- [122](https://github.com/alleslabs/celatone-frontend/pull/122) Fix unknown code upload block height +- [#122](https://github.com/alleslabs/celatone-frontend/pull/122) Fix unknown code upload block height - [#121](https://github.com/alleslabs/celatone-frontend/pull/121) Fix code snippet for query axios - [#76](https://github.com/alleslabs/celatone-frontend/pull/76) Add Public projects page - [#116](https://github.com/alleslabs/celatone-frontend/pull/116) Support Terra2.0 mainnet and testnet From b69d977626f68dcc4f48e9fb1836bda31cc2005f Mon Sep 17 00:00:00 2001 From: evilpeach Date: Tue, 24 Jan 2023 18:26:33 +0700 Subject: [PATCH 4/4] fix: height type in proposal --- src/lib/types/code.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/types/code.ts b/src/lib/types/code.ts index 031d9477a..a0c2b742e 100644 --- a/src/lib/types/code.ts +++ b/src/lib/types/code.ts @@ -21,7 +21,7 @@ export interface CodeInfo extends CodeLocalInfo { interface CodeProposal { proposalId: number; - height: number; + height: Option; created: Date; }