From e5b69fa2b92695e32bd1745d3bb3fa08d0c87c86 Mon Sep 17 00:00:00 2001 From: Sean Fisher Date: Thu, 9 May 2024 13:50:02 -0400 Subject: [PATCH] Fixing ddSql method (#549) * Fixing ddSql method * Ensure the script does die --- src/mantle/database/query/class-builder.php | 2 +- src/mantle/database/query/class-post-query-builder.php | 6 ++++-- src/mantle/database/query/class-term-query-builder.php | 6 ++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mantle/database/query/class-builder.php b/src/mantle/database/query/class-builder.php index 729d6a8a..bf5930bf 100644 --- a/src/mantle/database/query/class-builder.php +++ b/src/mantle/database/query/class-builder.php @@ -151,7 +151,7 @@ abstract public function dumpSql(): static; /** * Dump the SQL query for the request and stop execution. */ - abstract public function ddSql(): void; + abstract public function ddSql(): never; /** * Get a model instance for the builder. diff --git a/src/mantle/database/query/class-post-query-builder.php b/src/mantle/database/query/class-post-query-builder.php index e2b80b21..51580df3 100644 --- a/src/mantle/database/query/class-post-query-builder.php +++ b/src/mantle/database/query/class-post-query-builder.php @@ -340,7 +340,9 @@ function ( string $sql, \WP_Query $query ) use ( $die ) { /** * Dump the SQL query being executed and die. */ - public function ddSql(): void { - $this->dumpSql( true ); + public function ddSql(): never { + $this->dumpSql( true )->get(); + + die( 1 ); } } diff --git a/src/mantle/database/query/class-term-query-builder.php b/src/mantle/database/query/class-term-query-builder.php index 997a85cf..2f9b1ec1 100644 --- a/src/mantle/database/query/class-term-query-builder.php +++ b/src/mantle/database/query/class-term-query-builder.php @@ -173,7 +173,9 @@ function ( mixed $terms, \WP_Term_Query $query ) use ( $die ) { /** * Dump the SQL query being executed and die. */ - public function ddSql(): void { - $this->dumpSql( true ); + public function ddSql(): never { + $this->dumpSql( true )->get(); + + die( 1 ); } }