Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to WP Coding Standards #271

Closed
mboynes opened this issue Dec 20, 2014 · 38 comments
Closed

Adhere to WP Coding Standards #271

mboynes opened this issue Dec 20, 2014 · 38 comments
Milestone

Comments

@mboynes
Copy link
Member

@mboynes mboynes commented Dec 20, 2014

We are aiming to enforce the WordPress coding standards across the entire plugin.

We'd love some help doing this spring cleaning. Below is a list of files that need to be verified or updated. If you want to chip in, comment on this issue saying that you're going to take one, and we'll update the issue to say you're on it. Then simply submit a PR with the clean file when you're done.

PHP

  • fieldmanager.php
  • php/class-fieldmanager-autocomplete.php
  • php/class-fieldmanager-checkbox.php
  • php/class-fieldmanager-checkboxes.php
  • php/class-fieldmanager-colorpicker.php
  • php/class-fieldmanager-datepicker.php
  • php/class-fieldmanager-draggablepost.php
  • php/class-fieldmanager-field.php
  • php/class-fieldmanager-grid.php
  • php/class-fieldmanager-group.php
  • php/class-fieldmanager-hidden.php
  • php/class-fieldmanager-link.php
  • php/class-fieldmanager-media.php
  • php/class-fieldmanager-options.php
  • php/class-fieldmanager-password.php
  • php/class-fieldmanager-radios.php
  • php/class-fieldmanager-richtextarea.php
  • php/class-fieldmanager-select.php
  • php/class-fieldmanager-textarea.php
  • php/class-fieldmanager-textfield.php
  • php/context/class-fieldmanager-context-page.php
  • php/context/class-fieldmanager-context-post.php
  • php/context/class-fieldmanager-context-quickedit.php
  • php/context/class-fieldmanager-context-storable.php
  • php/context/class-fieldmanager-context-submenu.php
  • php/context/class-fieldmanager-context-term.php
  • php/context/class-fieldmanager-context-user.php
  • php/context/class-fieldmanager-context.php
  • php/datasource/class-fieldmanager-datasource-post.php
  • php/datasource/class-fieldmanager-datasource-term.php
  • php/datasource/class-fieldmanager-datasource-user.php
  • php/datasource/class-fieldmanager-datasource.php
  • php/util/class-fieldmanager-util-term-meta.php
  • php/util/class-fieldmanager-util-validation.php
  • templates/datepicker.php
  • templates/options-checkboxes.php
  • templates/options-radios.php
  • templates/textfield.php

JS

  • js/fieldmanager-autocomplete.js
  • js/fieldmanager-colorpicker.js
  • js/fieldmanager-datepicker.js
  • js/fieldmanager-draggablepost.js
  • js/fieldmanager-group-tabs.js
  • js/fieldmanager-post.js
  • js/fieldmanager-quickedit.js
  • js/fieldmanager-select.js
  • js/fieldmanager.js
  • js/grid.js
  • js/media/fieldmanager-media.js
  • js/richtext.js
  • js/validation/fieldmanager-validation.js
@mboynes mboynes added the enhancement label Dec 20, 2014
@mboynes mboynes added this to the 1.0 Beta milestone Dec 20, 2014
@mboynes mboynes self-assigned this Dec 21, 2014
@mboynes mboynes mentioned this issue Dec 22, 2014
2 of 3 tasks complete
@mboynes mboynes removed their assignment Dec 23, 2014
@mboynes mboynes modified the milestones: 1.0 Beta 3, 1.0.0 Beta 4 Jul 26, 2015
@mboynes mboynes modified the milestones: 1.0.0 Beta 4, later Dec 31, 2015
@mboynes mboynes modified the milestone: later Feb 19, 2016
@danielbachhuber danielbachhuber modified the milestones: 1.0.0 RC, later Feb 20, 2016
@danielbachhuber
Copy link
Collaborator

@danielbachhuber danielbachhuber commented Feb 20, 2016

We're set up to do cleanup now, but because of the code churn required, we should do it as the very last thing.

@mboynes mboynes modified the milestones: 1.0.0 RC, later, 1.1.0 Feb 20, 2016
@montchr
Copy link
Member

@montchr montchr commented Mar 11, 2016

If you still need help with this still, I'm willing to take a few files.

@danielbachhuber
Copy link
Collaborator

@danielbachhuber danielbachhuber commented Mar 11, 2016

If you still need help with this still, I'm willing to take a few files.

Great! I think now's a good time for it, given we're at the beginning of the next cycle and don't have too many outstanding pull requests.

Can you submit pull requests file by file, and enable PHPCS validation by Travis on the file at the beginning of the cleanup process? This will let us capture a failing build with all of the validations, and work towards a passing build.

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-quickedit.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-storable.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-submenu.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-term.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-user.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/datasource/class-fieldmanager-datasource-post.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 17, 2017

On php/datasource/class-fieldmanager-datasource-term.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 22, 2017

On php/datasource/class-fieldmanager-datasource-user.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 23, 2017

On php/datasource/class-fieldmanager-datasource.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 23, 2017

On php/util/class-fieldmanager-util-term-meta.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 23, 2017

On php/util/class-fieldmanager-util-validation.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 27, 2017

On templates/options-radios.php

@kjbenk
Copy link
Member

@kjbenk kjbenk commented Feb 27, 2017

On templates/textfield.php

@mboynes
Copy link
Member Author

@mboynes mboynes commented Oct 8, 2017

I don't think it's worthwhile to update the JS at this time. The JS for this plugin needs a complete overhaul, moving it to webpack, etc., so I'm going to mark this as resolved now that the PHP files are all done.

@mboynes mboynes closed this Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.