Adhere to WP Coding Standards

[mboynes]

We are aiming to enforce the WordPress coding standards across the entire plugin.

We'd love some help doing this spring cleaning. Below is a list of files that need to be verified or updated. If you want to chip in, comment on this issue saying that you're going to take one, and we'll update the issue to say you're on it. Then simply submit a PR with the clean file when you're done.

PHP

• fieldmanager.php
• php/class-fieldmanager-autocomplete.php
• php/class-fieldmanager-checkbox.php
• php/class-fieldmanager-checkboxes.php
• php/class-fieldmanager-colorpicker.php
• php/class-fieldmanager-datepicker.php
• php/class-fieldmanager-draggablepost.php
• php/class-fieldmanager-field.php
• php/class-fieldmanager-grid.php
• php/class-fieldmanager-group.php
• php/class-fieldmanager-hidden.php
• php/class-fieldmanager-link.php
• php/class-fieldmanager-media.php
• php/class-fieldmanager-options.php
• php/class-fieldmanager-password.php
• php/class-fieldmanager-radios.php
• php/class-fieldmanager-richtextarea.php
• php/class-fieldmanager-select.php
• php/class-fieldmanager-textarea.php
• php/class-fieldmanager-textfield.php
• php/context/class-fieldmanager-context-page.php
• php/context/class-fieldmanager-context-post.php
• php/context/class-fieldmanager-context-quickedit.php
• php/context/class-fieldmanager-context-storable.php
• php/context/class-fieldmanager-context-submenu.php
• php/context/class-fieldmanager-context-term.php
• php/context/class-fieldmanager-context-user.php
• php/context/class-fieldmanager-context.php
• php/datasource/class-fieldmanager-datasource-post.php
• php/datasource/class-fieldmanager-datasource-term.php
• php/datasource/class-fieldmanager-datasource-user.php
• php/datasource/class-fieldmanager-datasource.php
• php/util/class-fieldmanager-util-term-meta.php
• php/util/class-fieldmanager-util-validation.php
• templates/datepicker.php
• templates/options-checkboxes.php
• templates/options-radios.php
• templates/textfield.php

JS

• js/fieldmanager-autocomplete.js
• js/fieldmanager-colorpicker.js
• js/fieldmanager-datepicker.js
• js/fieldmanager-draggablepost.js
• js/fieldmanager-group-tabs.js
• js/fieldmanager-post.js
• js/fieldmanager-quickedit.js
• js/fieldmanager-select.js
• js/fieldmanager.js
• js/grid.js
• js/media/fieldmanager-media.js
• js/richtext.js
• js/validation/fieldmanager-validation.js

[danielbachhuber]

We're set up to do cleanup now, but because of the code churn required, we should do it as the very last thing.

[montchr]

If you still need help with this still, I'm willing to take a few files.

[danielbachhuber]

If you still need help with this still, I'm willing to take a few files.

Great! I think now's a good time for it, given we're at the beginning of the next cycle and don't have too many outstanding pull requests.

Can you submit pull requests file by file, and enable PHPCS validation by Travis on the file at the beginning of the cleanup process? This will let us capture a failing build with all of the validations, and work towards a passing build.

[kjbenk]

On php/context/class-fieldmanager-context-quickedit.php

[kjbenk]

On php/context/class-fieldmanager-context-storable.php

[kjbenk]

On php/context/class-fieldmanager-context-submenu.php

[kjbenk]

On php/context/class-fieldmanager-context-term.php

[kjbenk]

On php/context/class-fieldmanager-context-user.php

[kjbenk]

On php/context/class-fieldmanager-context.php

[kjbenk]

On php/datasource/class-fieldmanager-datasource-post.php

[kjbenk]

On php/datasource/class-fieldmanager-datasource-term.php

[kjbenk]

On php/datasource/class-fieldmanager-datasource-user.php

[kjbenk]

On php/datasource/class-fieldmanager-datasource.php

[kjbenk]

On php/util/class-fieldmanager-util-term-meta.php

[kjbenk]

On php/util/class-fieldmanager-util-validation.php

[kjbenk]

On templates/options-radios.php

[kjbenk]

On templates/textfield.php

[mboynes]

I don't think it's worthwhile to update the JS at this time. The JS for this plugin needs a complete overhaul, moving it to webpack, etc., so I'm going to mark this as resolved now that the PHP files are all done.