New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to WP Coding Standards #271

Closed
mboynes opened this Issue Dec 20, 2014 · 38 comments

Comments

Projects
None yet
5 participants
@mboynes
Member

mboynes commented Dec 20, 2014

We are aiming to enforce the WordPress coding standards across the entire plugin.

We'd love some help doing this spring cleaning. Below is a list of files that need to be verified or updated. If you want to chip in, comment on this issue saying that you're going to take one, and we'll update the issue to say you're on it. Then simply submit a PR with the clean file when you're done.

PHP

  • fieldmanager.php
  • php/class-fieldmanager-autocomplete.php
  • php/class-fieldmanager-checkbox.php
  • php/class-fieldmanager-checkboxes.php
  • php/class-fieldmanager-colorpicker.php
  • php/class-fieldmanager-datepicker.php
  • php/class-fieldmanager-draggablepost.php
  • php/class-fieldmanager-field.php
  • php/class-fieldmanager-grid.php
  • php/class-fieldmanager-group.php
  • php/class-fieldmanager-hidden.php
  • php/class-fieldmanager-link.php
  • php/class-fieldmanager-media.php
  • php/class-fieldmanager-options.php
  • php/class-fieldmanager-password.php
  • php/class-fieldmanager-radios.php
  • php/class-fieldmanager-richtextarea.php
  • php/class-fieldmanager-select.php
  • php/class-fieldmanager-textarea.php
  • php/class-fieldmanager-textfield.php
  • php/context/class-fieldmanager-context-page.php
  • php/context/class-fieldmanager-context-post.php
  • php/context/class-fieldmanager-context-quickedit.php
  • php/context/class-fieldmanager-context-storable.php
  • php/context/class-fieldmanager-context-submenu.php
  • php/context/class-fieldmanager-context-term.php
  • php/context/class-fieldmanager-context-user.php
  • php/context/class-fieldmanager-context.php
  • php/datasource/class-fieldmanager-datasource-post.php
  • php/datasource/class-fieldmanager-datasource-term.php
  • php/datasource/class-fieldmanager-datasource-user.php
  • php/datasource/class-fieldmanager-datasource.php
  • php/util/class-fieldmanager-util-term-meta.php
  • php/util/class-fieldmanager-util-validation.php
  • templates/datepicker.php
  • templates/options-checkboxes.php
  • templates/options-radios.php
  • templates/textfield.php

JS

  • js/fieldmanager-autocomplete.js
  • js/fieldmanager-colorpicker.js
  • js/fieldmanager-datepicker.js
  • js/fieldmanager-draggablepost.js
  • js/fieldmanager-group-tabs.js
  • js/fieldmanager-post.js
  • js/fieldmanager-quickedit.js
  • js/fieldmanager-select.js
  • js/fieldmanager.js
  • js/grid.js
  • js/media/fieldmanager-media.js
  • js/richtext.js
  • js/validation/fieldmanager-validation.js

@mboynes mboynes added the enhancement label Dec 20, 2014

@mboynes mboynes added this to the 1.0 Beta milestone Dec 20, 2014

@mboynes mboynes self-assigned this Dec 21, 2014

@mboynes mboynes referenced this issue Dec 22, 2014

Closed

Coding standards #276

2 of 3 tasks complete

@mboynes mboynes removed their assignment Dec 23, 2014

@mboynes mboynes modified the milestones: 1.0 Beta 3, 1.0.0 Beta 4 Jul 26, 2015

@mboynes mboynes modified the milestones: 1.0.0 Beta 4, later Dec 31, 2015

@mboynes mboynes modified the milestone: later Feb 19, 2016

@danielbachhuber danielbachhuber modified the milestones: 1.0.0 RC, later Feb 20, 2016

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Feb 20, 2016

Collaborator

We're set up to do cleanup now, but because of the code churn required, we should do it as the very last thing.

Collaborator

danielbachhuber commented Feb 20, 2016

We're set up to do cleanup now, but because of the code churn required, we should do it as the very last thing.

@mboynes mboynes modified the milestones: 1.0.0 RC, later, 1.1.0 Feb 20, 2016

@montchr

This comment has been minimized.

Show comment
Hide comment
@montchr

montchr Mar 11, 2016

Contributor

If you still need help with this still, I'm willing to take a few files.

Contributor

montchr commented Mar 11, 2016

If you still need help with this still, I'm willing to take a few files.

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Mar 11, 2016

Collaborator

If you still need help with this still, I'm willing to take a few files.

Great! I think now's a good time for it, given we're at the beginning of the next cycle and don't have too many outstanding pull requests.

Can you submit pull requests file by file, and enable PHPCS validation by Travis on the file at the beginning of the cleanup process? This will let us capture a failing build with all of the validations, and work towards a passing build.

Collaborator

danielbachhuber commented Mar 11, 2016

If you still need help with this still, I'm willing to take a few files.

Great! I think now's a good time for it, given we're at the beginning of the next cycle and don't have too many outstanding pull requests.

Can you submit pull requests file by file, and enable PHPCS validation by Travis on the file at the beginning of the cleanup process? This will let us capture a failing build with all of the validations, and work towards a passing build.

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 15, 2017

Member

I will pick up fieldmanager.php

Member

kjbenk commented Feb 15, 2017

I will pick up fieldmanager.php

@szepeviktor

This comment has been minimized.

Show comment
Hide comment
@szepeviktor

szepeviktor Feb 15, 2017

phpcbf can do miracles in 10 seconds.

szepeviktor commented Feb 15, 2017

phpcbf can do miracles in 10 seconds.

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 15, 2017

Member

On php/class-fieldmanager-autocomplete.php

Member

kjbenk commented Feb 15, 2017

On php/class-fieldmanager-autocomplete.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 16, 2017

Member

On php/class-fieldmanager-richtextarea.php

Member

kjbenk commented Feb 16, 2017

On php/class-fieldmanager-richtextarea.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 16, 2017

Member

On php/class-fieldmanager-select.php

Member

kjbenk commented Feb 16, 2017

On php/class-fieldmanager-select.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-page.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-page.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/class-fieldmanager-textfield.php

Member

kjbenk commented Feb 17, 2017

On php/class-fieldmanager-textfield.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-post.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-post.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-quickedit.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-quickedit.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-storable.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-storable.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-submenu.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-submenu.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-term.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-term.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context-user.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context-user.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/context/class-fieldmanager-context.php

Member

kjbenk commented Feb 17, 2017

On php/context/class-fieldmanager-context.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/datasource/class-fieldmanager-datasource-post.php

Member

kjbenk commented Feb 17, 2017

On php/datasource/class-fieldmanager-datasource-post.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 17, 2017

Member

On php/datasource/class-fieldmanager-datasource-term.php

Member

kjbenk commented Feb 17, 2017

On php/datasource/class-fieldmanager-datasource-term.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 22, 2017

Member

On php/datasource/class-fieldmanager-datasource-user.php

Member

kjbenk commented Feb 22, 2017

On php/datasource/class-fieldmanager-datasource-user.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 23, 2017

Member

On php/datasource/class-fieldmanager-datasource.php

Member

kjbenk commented Feb 23, 2017

On php/datasource/class-fieldmanager-datasource.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 23, 2017

Member

On php/util/class-fieldmanager-util-term-meta.php

Member

kjbenk commented Feb 23, 2017

On php/util/class-fieldmanager-util-term-meta.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 23, 2017

Member

On php/util/class-fieldmanager-util-validation.php

Member

kjbenk commented Feb 23, 2017

On php/util/class-fieldmanager-util-validation.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 27, 2017

Member

On templates/options-radios.php

Member

kjbenk commented Feb 27, 2017

On templates/options-radios.php

@kjbenk

This comment has been minimized.

Show comment
Hide comment
@kjbenk

kjbenk Feb 27, 2017

Member

On templates/textfield.php

Member

kjbenk commented Feb 27, 2017

On templates/textfield.php

@mboynes

This comment has been minimized.

Show comment
Hide comment
@mboynes

mboynes Oct 8, 2017

Member

I don't think it's worthwhile to update the JS at this time. The JS for this plugin needs a complete overhaul, moving it to webpack, etc., so I'm going to mark this as resolved now that the PHP files are all done.

Member

mboynes commented Oct 8, 2017

I don't think it's worthwhile to update the JS at this time. The JS for this plugin needs a complete overhaul, moving it to webpack, etc., so I'm going to mark this as resolved now that the PHP files are all done.

@mboynes mboynes closed this Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment