Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Network Settings submenus and network-wide settings #120

Closed
wants to merge 11 commits into from

Conversation

@dlh01
Copy link
Member

dlh01 commented Mar 14, 2014

No description provided.

@mboynes
Copy link
Member

mboynes commented Aug 31, 2014

@dlh01 can you add unit tests for this, and also integrate it with the new context hooks? FWIW, I just added unit tests in #197.

@dlh01
Copy link
Member Author

dlh01 commented Sep 17, 2014

@mboynes I've updated the functionality and added tests. I'm definitely open to suggestions about structuring the multisite-specific assertions.

@dlh01 dlh01 removed the needs-tests label Oct 3, 2014
mboynes added 2 commits Jun 26, 2015
# Conflicts:
#	fieldmanager.php
#	php/context/class-fieldmanager-context-submenu.php
#	tests/php/test-fieldmanager-context-submenu.php
also update WP versions
@mboynes
Copy link
Member

mboynes commented Jun 26, 2015

@dlh01 I brought this PR up to the present. Can you re-test this before we merge?

@dlh01
Copy link
Member Author

dlh01 commented Jun 26, 2015

Sure. Besides what Travis detected, it seems like this needs to properly extend Fieldmanager_Context_Storable now.

@mboynes
Copy link
Member

mboynes commented Jun 26, 2015

it seems like this needs to properly extend Fieldmanager_Context_Storable now

I think I adjusted everything that would need it, but you can double-check my changes.

The Travis error is unrelated, I'm looking into that now.

@mboynes mboynes modified the milestones: later, 1.1.0 Feb 20, 2016
@mboynes mboynes modified the milestones: 1.2.0, 1.3.0 Oct 8, 2017
@mboynes mboynes closed this Oct 10, 2017
@dlh01 dlh01 deleted the add-site-options branch Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.