User forms #157
User forms #157
Conversation
| $classes[] = 'fm-label-inline'; | ||
| } | ||
| if ( $this->label_after_element ) { | ||
| $classes[] = 'fm-label-after'; | ||
| } | ||
| // @TODO add inline and block to .label in stylesheet. Test this all. |
There was a problem hiding this comment.
Looks like this todo has been handled right?
|
I've tested the user-form branch locally with Selenium IDE and the forms I implemented for European Voice and all of them work fine: user registration, subscription payment, subscription renewal, profile form, and invoice payment. |
|
I've filed an issue slightly related to this: #158 |
|
I'm going to hold merging this until tests for Fieldmanager_File are written and FM Demos has an equivalent PR to demo a user-facing form. |
| type="file" | ||
| name="<?php echo $this->get_form_name(); ?>" | ||
| id="<?php echo $this->get_element_id(); ?>" | ||
| <?php echo $this->get_element_attributes(); ?> |
There was a problem hiding this comment.
Do these templates need escaping?
|
Not sure I'm in the right mindset to stamp this officially (too many consecutive pseudoephedrine days), but it does look good to me overall and I'm psyched to play with it (and the tests). |
|
|
…ss_class fix missing fm-element class for textfields
|
There's a function called fm_renumber in fieldmanager.js that takes care of assigning the correct name and id attributes to HTML elements in a Fieldmanager_Group. See https://github.com/alleyinteractive/wordpress-fieldmanager/blob/user-forms/js/fieldmanager.js#L76 That functions looks for a class .fm-element for each element but the template for textfield is not adding it automatically on this branch, see https://github.com/alleyinteractive/wordpress-fieldmanager/blob/user-forms/templates/textfield.php#L2 This causes information in textfields in a group not to be saved correctly. A workaround for this could be adding the field_class property to Fieldmanager_Textfield with this value: "fm-element text". This was fixed on #209 |
|
This should not delete |
|
I'm finally checking this out since I've replaced all calls to However, styles for the rendered form are a bit messed up:
Here's what it should look like normally:
Looks like that's happening because the parent of Also, could someone resolve the merge conflicts so I can test with the changes from master? |
User-facing forms to include in themes, etc.