New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldmanager ui update #468

Open
wants to merge 70 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@stevenslack
Member

stevenslack commented Feb 20, 2016

  • greater spacing between fields
  • repeatable / sortable UI improvements
  • media upload field provides more info about file uploaded
  • tab UI updates
  • new field CSS class which wraps just the label, field and description
  • labels and descriptions style updates
@mboynes

This comment has been minimized.

Show comment
Hide comment
@mboynes

mboynes Feb 20, 2016

Member
  • Test descriptions in horizontal tab groups
  • Test descriptions in vertical tab groups
  • Test descriptions in nested groups (2 and 3 levels deep)
Member

mboynes commented Feb 20, 2016

  • Test descriptions in horizontal tab groups
  • Test descriptions in vertical tab groups
  • Test descriptions in nested groups (2 and 3 levels deep)

@mboynes mboynes modified the milestone: 1.1.0 Feb 22, 2016

stevenslack added some commits Mar 18, 2016

corrects descriptions in tabbed field groups
* div to paragraph tag to prevent hiding from JS which targets sibling divs
* special handling for displaying the before description before the UL element in tabbed groups
border-right: none;
border-bottom: none;
border-left: none;
-webkit-box-shadow: none;

This comment has been minimized.

@ostowe

ostowe Mar 27, 2016

Member

At some point it'd probably be nice to set up webpack for FM (including autoprefixer).

@ostowe

ostowe Mar 27, 2016

Member

At some point it'd probably be nice to set up webpack for FM (including autoprefixer).

This comment has been minimized.

@stevenslack

stevenslack Mar 28, 2016

Member

Yes, we'd also like to set up SASS which will allow for a better organization of CSS

@stevenslack

stevenslack Mar 28, 2016

Member

Yes, we'd also like to set up SASS which will allow for a better organization of CSS

Show outdated Hide outdated css/fieldmanager.css
Show outdated Hide outdated css/fieldmanager.css
Show outdated Hide outdated css/fieldmanager.css
@ostowe

This comment has been minimized.

Show comment
Hide comment
@ostowe

ostowe Mar 27, 2016

Member

Styles are looking good over all, but had a few comments mostly related to mobile display.

Member

ostowe commented Mar 27, 2016

Styles are looking good over all, but had a few comments mostly related to mobile display.

@mslinnea

This comment has been minimized.

Show comment
Hide comment
@mslinnea

mslinnea Dec 17, 2016

Member

@stevenslack Overall, I really like these changes, but I did find a bug!

It's probably not a common use case, but in one theme I worked on we have several places where there are double-nested Fieldmanager_Groups. That's a Fieldmanager Group inside of a Fieldmanager Group inside of a Fieldmanager Group! Actually the admin interface is pretty complicated, so there could be something else going on, but these changes are breaking the tabs UI of the top level group. I'll send you a screenshot.

Member

mslinnea commented Dec 17, 2016

@stevenslack Overall, I really like these changes, but I did find a bug!

It's probably not a common use case, but in one theme I worked on we have several places where there are double-nested Fieldmanager_Groups. That's a Fieldmanager Group inside of a Fieldmanager Group inside of a Fieldmanager Group! Actually the admin interface is pretty complicated, so there could be something else going on, but these changes are breaking the tabs UI of the top level group. I'll send you a screenshot.

@stevenslack

This comment has been minimized.

Show comment
Hide comment
@stevenslack

stevenslack Dec 19, 2016

Member

@mslinnea addressed the issue you described. There were some edge cases where the sortable field handler was not positioned correctly in deeply nested group fields.

Member

stevenslack commented Dec 19, 2016

@mslinnea addressed the issue you described. There were some edge cases where the sortable field handler was not positioned correctly in deeply nested group fields.

@mslinnea

This comment has been minimized.

Show comment
Hide comment
@mslinnea

mslinnea Dec 20, 2016

Member

@stevenslack Looks good to me! Thanks for addressing those edge cases 😀 These UI improvements really do improve the look of repeatable fields.

Member

mslinnea commented Dec 20, 2016

@stevenslack Looks good to me! Thanks for addressing those edge cases 😀 These UI improvements really do improve the look of repeatable fields.

stevenslack and others added some commits Dec 22, 2016

Fix 3 phpcs errors in templates/datepicker.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 space before closing PHP tag; 0 found
    |       |     (Squiz.PHP.EmbeddedPhp.SpacingBeforeClose)
 29 | ERROR | [x] Inline PHP statement must end with a semicolon
    |       |     (Squiz.PHP.EmbeddedPhp.NoSemicolon)
 30 | ERROR | [x] Inline PHP statement must end with a semicolon
    |       |     (Squiz.PHP.EmbeddedPhp.NoSemicolon)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Merge branch 'master' into fm-ui-update
# Conflicts:
#	php/class-fieldmanager-field.php
#	php/class-fieldmanager-group.php
#	php/class-fieldmanager-media.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment