Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldmanager ui update #468

Open
wants to merge 70 commits into
base: master
from
Open

fieldmanager ui update #468

wants to merge 70 commits into from

Conversation

@stevenslack
Copy link
Member

stevenslack commented Feb 20, 2016

  • greater spacing between fields
  • repeatable / sortable UI improvements
  • media upload field provides more info about file uploaded
  • tab UI updates
  • new field CSS class which wraps just the label, field and description
  • labels and descriptions style updates
@mboynes
Copy link
Member

mboynes commented Feb 20, 2016

  • Test descriptions in horizontal tab groups
  • Test descriptions in vertical tab groups
  • Test descriptions in nested groups (2 and 3 levels deep)
stevenslack added 2 commits Feb 22, 2016
@mboynes mboynes modified the milestone: 1.1.0 Feb 22, 2016
stevenslack added 2 commits Mar 18, 2016
* div to paragraph tag to prevent hiding from JS which targets sibling divs
* special handling for displaying the before description before the UL element in tabbed groups
stevenslack and others added 24 commits Dec 23, 2016
This reverts commit ac1ec1c.
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 space before closing PHP tag; 0 found
    |       |     (Squiz.PHP.EmbeddedPhp.SpacingBeforeClose)
 29 | ERROR | [x] Inline PHP statement must end with a semicolon
    |       |     (Squiz.PHP.EmbeddedPhp.NoSemicolon)
 30 | ERROR | [x] Inline PHP statement must end with a semicolon
    |       |     (Squiz.PHP.EmbeddedPhp.NoSemicolon)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
# Conflicts:
#	php/class-fieldmanager-field.php
#	php/class-fieldmanager-group.php
#	php/class-fieldmanager-media.php
.fm-tabbed-vertical .fm-tab-bar {
width: 175px;
float: left;
margin: 0 0 0 -12px;

This comment has been minimized.

@montchr

montchr May 3, 2018 Member

I've checked this out locally and the -12px value causes vertical tabs to be offset incorrectly:

image 2018-05-03 at 11 58 29

Changing this to margin: 0 0 0 1px; fixes the issue for me. The 1px is to account for the border of a field group:

image 2018-05-03 at 12 01 37

This comment has been minimized.

@stevenslack

stevenslack May 30, 2018 Author Member

Thanks @montchr. The -12px was a way of setting the vertical tabs to the edge due to core's .postbox .inside 12 pixel padding.

I pushed up a small adjustment which will take precedence over the .postbox .inside padding for the vertical tab group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.