Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TFC virtual functions offsets under linux #354

Merged
merged 1 commit into from Feb 19, 2016

Conversation

@Arkshine
Copy link
Member

commented Feb 19, 2016

Reported by Rirre here : https://forums.alliedmods.net/showthread.php?t=279284

Linux needs +1.
First lines of some vtable dump under IDA:

VTable for CBasePlayer: (0, 0)
 Lin  Win Function
   0    0 CBasePlayer::~CBasePlayer()
   1    0 CBasePlayer::~CBasePlayer()
   2    1 CBasePlayer::Spawn(void)
   3    2 CBasePlayer::Precache(void)
...

@Arkshine Arkshine added the bug label Feb 19, 2016

@Arkshine Arkshine changed the title Fix TFC virtual functions indexes under linux Fix TFC virtual functions offsets under linux Feb 19, 2016

@Nextra

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2016

Looked over the changes quickly, seems to contain no mistakes.

🚢

Arkshine pushed a commit that referenced this pull request Feb 19, 2016
Vincent Herbet
Merge pull request #354 from Arkshine/update/tfc-vtable-linux
Fix TFC virtual functions offsets under linux

@Arkshine Arkshine merged commit f8dd3c0 into alliedmodders:master Feb 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Arkshine Arkshine deleted the Arkshine:update/tfc-vtable-linux branch Feb 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.