Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adminvote.sma exploit fix #823

Merged
merged 2 commits into from
May 28, 2020
Merged

Conversation

etojuice
Copy link
Contributor

@etojuice etojuice commented Jan 8, 2020

Restrict having ".." character sequence in amx_votemap command arguments

Fixes exploit on Windows servers that allows executing potentially dangerous console commands

Fixes exploit on Windows servers that allows executing potentially dangerous console commands
@OciXCrom
Copy link
Contributor

OciXCrom commented Jan 8, 2020

Not sure what the actual exploit is, but there's probably no need for a case-insensitive check.

containi -> contain
@etojuice
Copy link
Contributor Author

etojuice commented Jan 8, 2020

Not sure what the actual exploit is, but there's probably no need for a case-insensitive check.

Of course.

Copy link
Member

@Arkshine Arkshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I can't confirm, but I trust you did tested. This check won't hurt.

@Arkshine Arkshine merged commit a5f2b55 into alliedmodders:master May 28, 2020
Arkshine pushed a commit that referenced this pull request Jun 3, 2020
* Restrict having ".." character sequence in amx_votemap command arguments

Fixes exploit on Windows servers that allows executing potentially dangerous console commands

* Fix typo

containi -> contain
@etojuice etojuice deleted the adminvote-patch branch June 4, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants