dvander foxes

core/sourcehook/sh_memory.h

@@ -248,7 +248,7 @@ namespace SourceHook
 	*/
 	namespace
 	{
-		bool ModuleInMemory(char *addr, size_t len)
+		static inline bool ModuleInMemory(char *addr, size_t len)
 		{
 #if SH_SYS == SH_SYS_LINUX
 			// On linux, first check /proc/self/maps
@@ -322,10 +322,8 @@ namespace SourceHook
 			prevHandler = signal(SIGSEGV, BadReadHandler);
 
 			volatile const char *p = reinterpret_cast<const char*>(addr);
-			char dummy;
-
 			for (size_t i = 0; i < len; i++)
-				dummy = p[i];
+				p[i];
 
 			g_BadReadCalled = false;
 
@@ -346,10 +344,8 @@ namespace SourceHook
 				return false;
 
 			volatile const char *p = reinterpret_cast<const char *>(addr);
-			char dummy;
-
 			for (size_t i = 0; i < len; i++)
-				dummy = p[i];
+				p[i];
 
 			g_BadReadCalled = false;