Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L4D1 & 2 using the wrong file path for matchmaking_ds #1006

Closed
Psykotikism opened this issue May 10, 2019 · 3 comments
Labels
Bug

Comments

@Psykotikism
Copy link
Contributor

@Psykotikism Psykotikism commented May 10, 2019

Help us help you

  • I have checked that my issue doesn't exist yet.
  • I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
  • I can always reproduce the issue with the provided description below.

Environment

  • Operating System version: Win & Lin
  • Game/AppID (with version if applicable): 500 & 550
  • Current SourceMod version: 1.10
  • Current SourceMod snapshot: 6407

Description

Both Left 4 Dead games have their matchmaking_ds files inside {mod folder}/bin, and currently SM is set up to look for that file inside {mod folder}/bin/{platform}.

Maybe you guys could make an exception for L4D1&2 to define PLATFORM_FOLDER as "" for those games? Just a suggestion.

For convenience, the file path is defined here: https://github.com/alliedmodders/sourcemod/blob/master/core/logic_bridge.cpp#L633

Problematic Code (or Steps to Reproduce)

N/A

Logs

  • N/A
@asherkin

This comment has been minimized.

Copy link
Member

@asherkin asherkin commented May 10, 2019

Thanks for the report. Please add some detail on how this is affecting you such as explaining what is not working or including error logs you are getting from it not being found.

@Psykotikism

This comment has been minimized.

Copy link
Contributor Author

@Psykotikism Psykotikism commented May 10, 2019

Here are the logs on my L4D2 server upon start-up. I have also attached the plugin and the gamedata file associated with it so you can test for yourself.
l4d-changemission.zip

@asherkin

This comment has been minimized.

Copy link
Member

@asherkin asherkin commented May 11, 2019

It looks like this might be wrong for all games on Linux, I suspect the paths here are specific to macOS (or possibly just the client distributions in general).

@Headline Headline added the Bug label May 24, 2019
psychonic added a commit that referenced this issue Jun 1, 2019
psychonic added a commit that referenced this issue Jun 1, 2019
@psychonic psychonic closed this Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.