Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created GlobalForward and Forward methodmaps #1004

Merged
merged 10 commits into from May 29, 2019
Merged

Created GlobalForward and Forward methodmaps #1004

merged 10 commits into from May 29, 2019

Conversation

@JoinedSenses
Copy link
Contributor

@JoinedSenses JoinedSenses commented May 9, 2019

This PR introduces types GlobalForward and Forward by creating methodmaps for the two. Pretty straight forward. As usual, please let me know if something looks off or could use improvement.

plugins/include/functions.inc Outdated Show resolved Hide resolved
@JoinedSenses
Copy link
Contributor Author

@JoinedSenses JoinedSenses commented May 12, 2019

Another thought I have regarding this is to add all Call_ functions as static to the methodmap

plugins/include/functions.inc Outdated Show resolved Hide resolved
plugins/include/functions.inc Outdated Show resolved Hide resolved
plugins/include/functions.inc Outdated Show resolved Hide resolved
plugins/include/functions.inc Outdated Show resolved Hide resolved
}
};

methodmap Forward < GlobalForward {
Copy link
Member

@asherkin asherkin May 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about PrivateForward? That is what we call it in the doc comment and it feels more balanced against GlobalForward (which is generally the one people are using anyway). That said, calling them "private" and "global" forwards has never really made sense and this is a good opportunity to change the terminology, some nomenclature around "managed" might be clearer?

Copy link
Contributor Author

@JoinedSenses JoinedSenses May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to have PrivateForward instead of just Forward. If not "private" and "global", you're suggesting "managed" and "unmanaged"? Something about these terms don't sit right with me, perhaps because it's terminology i've already come to terms with. That and "private"/"global" are referenced in a ton of places already, so it might be weird going back on that.

Copy link
Member

@Headline Headline May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah; what happened?

Copy link
Contributor Author

@JoinedSenses JoinedSenses May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill fix tonight, uncaught change when reverting whitespace commit

Copy link
Contributor Author

@JoinedSenses JoinedSenses May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This oversight has been addressed in the latest commit. 26eb127

Copy link
Member

@Headline Headline left a comment

I'm cool with taking this

@Headline Headline requested a review from asherkin May 28, 2019
}
};

methodmap Forward < GlobalForward {
Copy link
Member

@Headline Headline May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah; what happened?

This was an oversight on my end due to trying to revert changes.
Copy link
Member

@asherkin asherkin left a comment

Love it.

@asherkin asherkin requested a review from Headline May 29, 2019
Copy link
Member

@Headline Headline left a comment

Looks good

@Headline Headline merged commit 4f3c317 into alliedmodders:master May 29, 2019
2 checks passed
@JoinedSenses JoinedSenses deleted the patch-4 branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants