Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFCond Descriptions #1005

Merged
merged 3 commits into from Jun 1, 2019

Conversation

@Batfoxkid
Copy link
Contributor

Batfoxkid commented May 9, 2019

Adds comments about the conditions in tf2.inc. This is mainly for the API to show description of the condition. Just a small thing.

This is mainly for API (https://sm.alliedmods.net/new-api/tf2/TFCond) to show description of the condition.
@KyleSanderson

This comment has been minimized.

Copy link
Member

KyleSanderson commented May 9, 2019

Where were these sourced from?

@Batfoxkid

This comment has been minimized.

Copy link
Contributor Author

Batfoxkid commented May 10, 2019

Where were these sourced from?

https://wiki.teamfortress.com/wiki/Cheats#addcond
Main place and my own experience using them.

Copy link
Contributor

404UNFca left a comment

Very nice, very helpful too.

Yee
@asherkin

This comment has been minimized.

Copy link
Member

asherkin commented May 31, 2019

I think I would prefer this without the numbers - if the numeric values are useful they should be specified as part of the enum or displayed by the doc tool. Thoughts?

@Batfoxkid

This comment has been minimized.

Copy link
Contributor Author

Batfoxkid commented May 31, 2019

Probably yeah, I do like some way of showing numeric values so that way for people who don't want to use the full name and instead do view_as<Enum>(#)

Copy link
Member

asherkin left a comment

A lot of people seem to like the numbers for this enum, so lets take this with them and look at a large doctool change later.

@asherkin asherkin merged commit cf0a498 into alliedmodders:master Jun 1, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.