Fix Miscellaneous Regressions and UBs #1022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the cppcheck static analyzer against /core/ to check if we were doing any ugliness that I didn't know about. Turns out there's a few situations where we were regressed.
First, and likely the most significant, was
CExtension::FindNextDependency
. This method must not have worked correctly for many many years. All operations were mistakenly done on a default-constructed iterator.Secondly,
realloc
can fail. By doing assignment directly on the result ofrealloc
we miss the opportunity to check if the retval is null or not. If it is null, then our memory allocated previously is still valid and we've just successfully leaked it. For the case involvingInternalFormat
, an exception was added for realloc failures.Finally,
1<<31
is undefined behavior as1
is an int32.Also switched some casts to static_cast because this is c++, after all...