Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Miscellaneous Regressions and UBs #1022
Ran the cppcheck static analyzer against /core/ to check if we were doing any ugliness that I didn't know about. Turns out there's a few situations where we were regressed.
First, and likely the most significant, was
Also switched some casts to static_cast because this is c++, after all...
Since dependency iteration has never historically functioned correctly, it is now deprecated.
Extensions have a very specific place alongside SourceMod, and their goal is to extend SourceMod's plugin API and provide an extension to SourceMod functionality. There was never really a need for this feature in the first place and this change allows us to further solidify our expectations for what an extension is meant to be.