Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPOTB: Fix GCC 9 Builds #1024

Merged
merged 1 commit into from May 29, 2019

Conversation

@Headline
Copy link
Member

Headline commented May 29, 2019

GCC 9 was released earlier this month and I happened to have accidentially installed it on my new fedora machine. Turns out the addition of some new warnings prevented builds to pass.

This obviously doesn't fix the actual warnings the compiler is referring to. I'm more concerned about the memseting that we're doing and I'll submit a patch in the future(TM) to address that directly to correct what it's warning about, but the other warning (packed-not-aligned) is found in the hl2sdk so there's not much we can do about it.

Michael Flaherty
@Headline Headline added the NPOTB label May 29, 2019
@Headline Headline merged commit 2164f51 into master May 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Headline Headline deleted the gcc-9.1.1-fix branch May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.