Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client id to MultiTargetFilter forward. #1070

Merged

Conversation

BotoX
Copy link
Contributor

@BotoX BotoX commented Sep 2, 2019

Add backwards compat stuff maybe? has Capability something ...

@peace-maker
Copy link
Member

This looks like a simpler duplicate of #478
A capability could indeed be useful, as mentioned in that other PR. IShareSys::AddCapabilityProvider

@BotoX BotoX force-pushed the feature-MultiTargetFilter-clientid branch from 14e4794 to f8f48e6 Compare September 10, 2019 09:22
@BotoX BotoX force-pushed the feature-MultiTargetFilter-clientid branch from f8f48e6 to 530d3c9 Compare July 9, 2020 12:47
@KyleSanderson
Copy link
Member

@asherkin how do you feel about this one?

@KyleSanderson
Copy link
Member

@asherkin this still looks OK to me, WDYT?

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM

@KyleSanderson KyleSanderson merged commit 1a11d92 into alliedmodders:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants