Avoid losing console messages.

[BotoX]

Buffers up to 16k bytes of SVC_Print if buffer would overflow, then sends chunks every frame.
Sends up to 2048 bytes per frame and does not split messages.

Only tested on cstrike, works without any changes on plugins.
On client the order is still messed up sometimes because the client itself fucks up the order (also on console commands like find)

[peace-maker]

This is great! This'll help getting some console logs in deterministically in order.
Some notes inline.

[peace-maker]

Some named constants instead of these magic values would be nice. Are they the same for all engines?

[BotoX]

bool SVC_Print::WriteToBuffer( bf_write &buffer )
{
	buffer.WriteUBitLong( GetType(), NETMSG_TYPE_BITS );
	return buffer.WriteString( m_szText ? m_szText : " svc_print NULL" );
}

NETMSG_TYPE_BITS is 5 in 2007 code, can't tell for sure if it's 6 in sdk2013 or I did that by trial&error or for safety reasons.
2048 is the size of the buffer in SVC_Print (also 2007 code), -1 for terminating \0 at the end of the string.
This just checks if the string is too big to fit into the current SVC_Print buffer so it doesn't have to be 100% accurate, the 2048 bufsize in SVC_Print is the most important.

[Headline]

Just some cleanup, no need for us to have our own list and manage it

[peace-maker]

We should reset the buffer in CPlayer::Disconnect.

[Headline]

I'm cool with code quality, here. Dismissing the rest to others

[Fyren]

Has this been tried on something other than BotoX's CSS servers?

[BotoX]

I didn't try it anywhere else, but SVC_Print should be the same across all games/engines.
I mean really all this does is buffer messages when the unreliable netchan has more than ~2000 bytes in it and send them in the next tick.
There's barely anything else that uses the unreliable netchan, especially not anything as big as SVC_Print.
So it could be less performant in other games if other stuff uses up the unreliable netchan and then console messages would be a bit slower.
However that's still better than outright losing them.

It obviously makes sense to test this on other games before merging, just put 64 bots on a server and type status. (should yield more than 2048 characters)
Without this patch the message will be cut off and you'll get this error:
Netchannel: failed reading message svc_Print from <serverip>

[KyleSanderson]

I've likely bikeshedded this to death. Just needs testing then should be good to ship.

[nosoop]

Verified working on CS:GO and TF2 (Linux) with the PR merged into branch 1.10-dev. Tested with the following plugin:

#pragma semicolon 1
#include <sourcemod>

#pragma newdecls required

public void OnPluginStart() {
	RegAdminCmd("sm_overflowsvcprint", OverflowConsoleBuffer, ADMFLAG_ROOT);
}

public Action OverflowConsoleBuffer(int client, int argc) {
	for (int i; i < 512; i++) {
		PrintToConsole(client, "%04d: %08x %08x %08x %08x %08x %08x %08x %08x",
				i, GetURandomInt(), GetURandomInt(), GetURandomInt(), GetURandomInt(),
				GetURandomInt(), GetURandomInt(), GetURandomInt(), GetURandomInt());
	}
	return Plugin_Handled;
}

[KyleSanderson]

Thank you very much, sorry for the huge delay.