Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin map chooser not using display names for menu #1097

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

nosoop
Copy link
Contributor

@nosoop nosoop commented Oct 7, 2019

From the SM Discord:

4:52 PM] HiGPS: Is there any plugin that helps with the workshop map names not working properly in TF2, they show ID's and not the map names in the admin menu , but works in the nominations menu

This copies the display name-related lines from the LoadMapList function in basevotes/votemap.sp to basecommands/map.sp. It's otherwise left as-is — I'd have no issues changing the styling / hoisting the variable declaration to make it more consistent if desired.

@asherkin asherkin merged commit 024ae2b into alliedmodders:master Oct 7, 2019
@nosoop nosoop deleted the adminmenu-choosemap-display branch October 8, 2019 01:42
@TheByKotik
Copy link
Contributor

i'm think is not good idea.
Maps can have same name but must have unique paths.

1

@nosoop
Copy link
Contributor Author

nosoop commented Oct 8, 2019

That's already an issue with using display names in the votemap menu with PR #354.

Personally, I'm indifferent on disambiguation (how many server ops have maps that share the same exact display name?). Having a togglable option to use the result of FindMap instead of GetMapDisplayName might be a compromise worth looking into; @TheByKotik might want to file an issue on it to get a proper discussion going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants