Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classic knife to CSWeaponID #1111

Merged
merged 1 commit into from Oct 31, 2019
Merged

Conversation

Bara
Copy link
Contributor

@Bara Bara commented Oct 31, 2019

Instead of KNIFE_CSS i would call it WEAPON_CLASSIC, like it Valve does.

#1105

Instead of KNIFE_CSS i would call it WEAPON_CLASSIC, like it [Valve](http://media.steampowered.com/apps/csgo/blog/images/cs20/knife13.png) does.

alliedmodders#1105
@Headline Headline merged commit 273f058 into alliedmodders:master Oct 31, 2019
@sneak-it
Copy link
Contributor

sneak-it commented Nov 2, 2019

But Valve does not call it that, it is weapon_knife_css:

Image

We should be consistent with the rest of the knife names, no? The rest of the entries utilize the items manifest names, I don't think we should change this now.

@Bara @Headline @asherkin

@Headline
Copy link
Member

Headline commented Nov 2, 2019

it’s now a breaking change to change the name, but I don’t think it’s a big deal

@Bara
Copy link
Contributor Author

Bara commented Nov 2, 2019

Breaking change from 2 days old change in a pretty new dev branch/version? 🤔

The official name is "Classic Knife" (csgo_english.txt -> "SFUI_WPNHUD_KnifeCSS") and for internal stuff (files, classname, ...) "knife_css".

@Headline
Copy link
Member

Headline commented Nov 2, 2019

if you updated and started using it, changing the name would break scripts, so yes unfortunately

should be fine as-is, but if there’s a real push for this to be changed something can be worked out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants