fix incorrect command reply in nominations

[thorgot]

When a map is nominated and the max nominations have been reached, the wrong text is returned if the map hasn't been nominated yet. Instead of printing the "Max Nominations" text, it prints out the "Map Already Nominated" text instead.

[Headline]

Thanks for contributing!

Looking over this, I'm seeing an explicit check for maps that have already been nominated. I believe something more nefarious is going on than a simple logic issue. The part you have edited, from what I've observed, is only possible to be hit when the map list is full, indicating to me that the original message is correct

sourcemod/plugins/nominations.sp

Lines 323 to 326 in de1a186

	if ((status & MAPSTATUS_EXCLUDE_NOMINATED) == MAPSTATUS_EXCLUDE_NOMINATED)
	{
	ReplyToCommand(client, "[SM] %t", "Map Already Nominated");
	}

[thorgot]

Thanks for contributing!

Looking over this, I'm seeing an explicit check for maps that have already been nominated. I believe something more nefarious is going on than a simple logic issue. The part you have edited, from what I've observed, is only possible to be hit when the map list is full, indicating to me that the original message is correct

sourcemod/plugins/nominations.sp

Lines 323 to 326 in de1a186

	if ((status & MAPSTATUS_EXCLUDE_NOMINATED) == MAPSTATUS_EXCLUDE_NOMINATED)
	{
	ReplyToCommand(client, "[SM] %t", "Map Already Nominated");
	}

MAPSTATUS_DISABLED is the status flag when the map is disabled in the nominate menu. The block you linked to is reached when the map has been nominated already, is the current map, or is in the exclude list (which is the last X maps). A map which has not been nominated, has not been played recently, and is not the current map will skip that entire if block and reach the line I changed.

[Headline]

Oh; I see, my mistake.

Thank you for clarifying, I was a little confused about what was going on. I was under the impression that Max Nominations was being replaced with Map Already Nominated for some reason, but this all appears correct.

Thank you very much!

[Headline]

🚢