Fix heap corruption in CUtlVector destructor #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CHalfLife2::FindMap` works around the missing `IVEngineServer::FindMap` function by using the command autocompletion feature of the `changelevel` command. The function populates a `CUtlVector<CUtlString>` object with the auto completion results. The game allocates memory for the vector and strings and we try to free it. This crashes when the C Run-time library version differs. Fixes alliedmodders#910 like @psychonic suggested.
|
Hm, looks like |
Looks like only hl2sdk-csgo has `CUtlMemory::Detach()`, so try not use it for other games like l4d.
|
Ok, looks like I can reuse the existing shims for |
Headline
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHalfLife2::FindMapworks around the missingIVEngineServer::FindMapfunction by using the command autocompletion feature of thechangelevelcommand.The function populates a
CUtlVector<CUtlString>object with the auto completion results. The game allocates memory for the vector and strings and we try to free it. This crashes when the C Run-time library version differs, which can happen when compiling using a newer toolchain.Fixes #910 like @psychonic suggested.
I've only tested this on CS:GO Windows. This allowed me to run my server with a self-compiled build of SourceMod.