Fix issue #1170 - #1172
Merged
Merged
Conversation
and removed IsSoundPrecached checks for GetGameSoundParams, too
asherkin
requested changes
Feb 3, 2020
asherkin
left a comment
asherkin
left a comment
Member
There was a problem hiding this comment.
Nice find!
I think it'll be a good idea to add a note to IsSoundPrecached warning that this function may not work correctly (always returning
true)
Might as well do that as part of this change (and mark it as #deprecated too).
The another comment is not needed, however.
Contributor
Author
|
I'm not sure what else is required here. |
asherkin
approved these changes
Feb 3, 2020
asherkin
left a comment
asherkin
left a comment
Member
There was a problem hiding this comment.
Nothing else is required, this all looks good.
I'll pull it when I'm at a proper computer and can merge it into 1.10 at the same time.
Contributor
Author
|
Alright! |
Headline
approved these changes
Feb 6, 2020
Headline
left a comment
Headline
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I'll go ahead and take this now
Headline
pushed a commit
that referenced
this pull request
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing some testing with a debugger, I noticed that
engsound->IsSoundPrecached(waveName)returnstrue, even though the sound is not precached. Because I don't have the patience to compile Sourcemod, I replaced the jnz instruction with nops and now sounds are successfully precached.For this reason, I removed
IsSoundPrecachedfromPrecacheSoundScriptandGetGameSoundParametersI think it'll be a good idea to add a note to IsSoundPrecached warning that this function may not work correctly(always returning
true)Fixes issue #1170