mapchooser: Fix previous map exclusion bug #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where if the value of `sm_mapvote_exclude` is reduced, the change may not take effect right away.
This was referenced Mar 7, 2020
KyleSanderson
approved these changes
Jul 9, 2020
|
Interesting catch, thanks! |
TheByKotik
reviewed
Jul 9, 2020
| @@ -260,7 +260,7 @@ public void OnMapEnd() | |||
| RemoveStringFromArray(g_OldMapList, map); | |||
| g_OldMapList.PushString(map); | |||
|
|
|||
| if (g_OldMapList.Length > g_Cvar_ExcludeMaps.IntValue) | |||
| while (g_OldMapList.Length > g_Cvar_ExcludeMaps.IntValue) | |||
| { | |||
| g_OldMapList.Erase(0); | |||
| } | |||
There was a problem hiding this comment.
Maybe better do something like this?
if ( g_OldMapList.Length > g_Cvar_ExcludeMaps.IntValue )
{
g_OldMapList.Resize( Cvar_ExcludeMaps.IntValue );
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where if the value of
sm_mapvote_excludeis reduced, the change may not take effect for an extended period of time. The size of the old map list is not updated when this happens.