Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when invalid address passed to SDKCall raw ptr #1265

Merged

Conversation

FortyTwoFortyTwo
Copy link
Contributor

LoadFromAddress and StoreToAddress throws error when null or below VALID_MINIMUM_MEMORY_ADDRESS is passed, but SDKCall with this as raw address does not have one. Throw error and prevent crash from doing so.

@KyleSanderson KyleSanderson merged commit f27dc2f into alliedmodders:master Jul 9, 2020
@KyleSanderson
Copy link
Member

Great idea, thanks for the contribution 😸

@FortyTwoFortyTwo FortyTwoFortyTwo deleted the sdkcall-address branch July 9, 2020 11:44
@dragokas
Copy link
Contributor

dragokas commented Dec 9, 2020

Some questions, related to "ThisPtr address cannot be null", if you don't mind:
https://forums.alliedmods.net/showthread.php?t=329123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants