Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string_t SetEntPropString support for ep1 (fixes #1287) #1299

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

psychonic
Copy link
Member

Quick and dirty fix for #1287

Copy link

@DarthMan DarthMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works perfect :-)

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes here look good, but I'm pretty sure this'll break the Dark Messiah build - which has gotten lost from the SE_ range here (ep1 is 1, dm is 2, and ob is 3).

Guessing this code'll work fine on DM as well, so it probably just needs to be SOURCE_ENGINE < SE_ORANGEBOX?

@DarthMan
Copy link

Nice! The changes here look good, but I'm pretty sure this'll break the Dark Messiah build - which has gotten lost from the SE_ range here (ep1 is 1, dm is 2, and ob is 3).

Guessing this code'll work fine on DM as well, so it probably just needs to be SOURCE_ENGINE < SE_ORANGEBOX?

I guess it will. Anyway, my priority now is just Fortress Forever. So it's ok, but sure, if it's gonna work fine for DM too, u could just change it to work for source engine < orangebox.

@psychonic
Copy link
Member Author

Nice! The changes here look good, but I'm pretty sure this'll break the Dark Messiah build - which has gotten lost from the SE_ range here (ep1 is 1, dm is 2, and ob is 3).

Guessing this code'll work fine on DM as well, so it probably just needs to be SOURCE_ENGINE < SE_ORANGEBOX?

Good catch. Thanks

@psychonic psychonic merged commit dea3ef7 into master Jun 29, 2020
@psychonic psychonic deleted the issue_1287 branch June 29, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants