Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 'checkout-deps' to check for 'pip'/'pip3' prior to installing 'AMBuild' #1328

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Updated 'checkout-deps' to check for 'pip'/'pip3' prior to installing 'AMBuild' #1328

merged 1 commit into from
Jul 31, 2020

Conversation

WildCard65
Copy link
Contributor

checkout-deps (PowerShell/BASH):

  • Checks for an active 'python'/'python3' command.
  • Checks for an active pip installation in the detected Python installation, otherwise, it installs it via 'get-pip.py'

checkout-deps.ps1

  • Added fallback to 'py'.

Closes #1324
See: alliedmodders/ambuild#68

@WildCard65
Copy link
Contributor Author

@dvander Care to review this please?

@dvander
Copy link
Member

dvander commented Jul 31, 2020

It strikes me that we should probably throw these scripts into a common repository, updating them in ~5 places is painful. Oh well, another day. Thanks for doing this.

@dvander dvander merged commit 9bbbf60 into alliedmodders:master Jul 31, 2020
@WildCard65 WildCard65 deleted the checkout-deps_fixes branch July 31, 2020 22:50
@peace-maker
Copy link
Member

I've noticed, with this change checkout-deps doesn't update ambuild anymore if it is already installed. I liked that behavior beforehand, being able to run one script to get the build environment up-to-date.

@WildCard65
Copy link
Contributor Author

WildCard65 commented Aug 19, 2020 via email

@peace-maker
Copy link
Member

I thought pip is only invoked, when import ambuild2 fails? So it won't upgrade when it's installed. --upgrade might help too.

@WildCard65
Copy link
Contributor Author

Oh, the PowerShell script didn't check for AMbuild beforehand while the shell script did.
I changed it to behave like the shell script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash sourcemod/tools/checkout-deps.sh fails to run
3 participants