Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill CDataPack cache #1357

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Kill CDataPack cache #1357

merged 1 commit into from
Oct 2, 2020

Conversation

Headline
Copy link
Member

Killing CDataPack's cache has been something on my list for a while - I'm not exactly sure when this became so easy (probably once IDataPack died), but here we are.

Technically, before this patch, we'd hold on to datapacks forever and their memory was never freed, we'd just save them for reuse. I do not think we're concerned anymore with the cost of allocating and deallocating this memory as-needed, so I'm just removing some bloat here.

@Headline Headline added the Bug general bugs; can be anything label Sep 30, 2020
@KyleSanderson KyleSanderson merged commit ef36604 into master Oct 2, 2020
@Headline Headline deleted the kill-dp-cache branch October 2, 2020 23:04
@KyleSanderson
Copy link
Member

Indeed. CPUs over the past decade + have come a long way with caching. This was a great feature at the time, but garbage collecting like this now per type is not really necessary (and may actually increase fragmentation / misses).

@Headline Headline added the hacktoberfest-accepted opt-in for hacktoberfest prs label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug general bugs; can be anything hacktoberfest-accepted opt-in for hacktoberfest prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants