Fix sm_dump_netprops_xml #1360
Merged
Fix sm_dump_netprops_xml #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headline
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some quirks with
sm_dump_netprops_xml. I ran into some problems parsing this a few months back.Adds an main tree.
Netprops can commonly use
"in their names ("healing_array"in TF2 for example), but xml supports using both single and double quotes in attribute values, so now it opts to put in single quotes.Edit:
I've provided a sample netprop dump for TF2 along with a basic Python script so you can compare the difference between them if you'd like. Script will fail with current command functionality.