Improvements on !admin menu flags #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets say we have override the sm_unmute command and changed it to ADMFLAG_CUSTOM1. Then create an admin, we gived our admin ADMFLAG_Chat flag, admin can't use sm_unmute command cause it doesnt have access to this command. But if admin go into "!admin" menu then, he will able to run sm_unmute on "player command" menus
Member
|
Nice catch. I'm not sure if showing the disabled options is useful though. You should just not add the menu option at all if the user doesn't have access to it. |
Contributor
Author
|
i made this way because if the admin wants to see if user gagged or not. It can be changed easily |
Member
|
Seeing who is muted is part of the permission in my opinion. If you can't use sm_mute you shouldn't see anything about it anywhere. |
Contributor
Author
|
Well, I changed it according to your opinion |
peace-maker
requested changes
Oct 23, 2020
Member
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
Thank you, this looks good except for the nits! 👍
Member
|
Thank you! |
Member
|
Was this already fixed in master? (I don’t have a PC handy but saw merged to 1.10-dev)
…Sent from my iPhone
On Oct 24, 2020, at 1:22 PM, peace-maker ***@***.***> wrote:
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
asherkin
pushed a commit
that referenced
this pull request
Oct 24, 2020
* Improvements on !admin menu flags Lets say we have override the sm_unmute command and changed it to ADMFLAG_CUSTOM1. Then create an admin, we gived our admin ADMFLAG_Chat flag, admin can't use sm_unmute command cause it doesnt have access to this command. But if admin go into "!admin" menu then, he will able to run sm_unmute on "player command" menus * removed unauthorized menu items * Deleted Whitespace and ITEMDRAW_DEFAULT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets say we have override the sm_unmute command and changed it to ADMFLAG_CUSTOM1.
Then create an admin, we gived our admin ADMFLAG_Chat flag, admin can't use sm_unmute command cause it doesnt have access to this command.
But if admin go into "!admin" menu then, he will able to run sm_unmute on "player command" menus
this vulnerability also affects mute,gag and silence commands