Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cookie funcs to return Cookie methodmap #1379

Merged
merged 5 commits into from
Nov 7, 2020
Merged

Update cookie funcs to return Cookie methodmap #1379

merged 5 commits into from
Nov 7, 2020

Conversation

JoinedSenses
Copy link
Contributor

Just like the behavior of functions like CreateArray which return ArrayList, cookie functions should return Cookie.

@JoinedSenses
Update cookie funcs to return Cookie methodmap
afd2202 
Just like the behavior of functions like CreateArray which return ArrayList, cookie functions should return Cookie.
@JoinedSenses
Update comment for null
324997a
@JoinedSenses
Update comment for null
5781a65
peace-maker
peace-maker requested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the keyword is lowercase, documenting it as Null might confuse users when they copy it from the docs? INVALID_HANDLE had unambiguous casing before 😄

plugins/include/clientprefs.inc Outdated Show resolved Hide resolved
plugins/include/clientprefs.inc Outdated Show resolved Hide resolved
JoinedSenses and others added 2 commits November 5, 2020 07:29
@JoinedSenses @peace-maker
Update plugins/include/clientprefs.inc
82e31bb 
Co-authored-by: peace-maker <peace-maker@wcfan.de>
@JoinedSenses @peace-maker
Update plugins/include/clientprefs.inc
1626704 
Co-authored-by: peace-maker <peace-maker@wcfan.de>
@JoinedSenses
Copy link
Contributor Author

JoinedSenses commented Nov 5, 2020 •
edited
Loading

Since the keyword is lowercase, documenting it as Null might confuse users when they copy it from the docs? INVALID_HANDLE had unambiguous casing before 😄

¯\_(ツ)_/¯

peace-maker
peace-maker approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Headline
Headline approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@Headline Headline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Headline Headline merged commit 0caa349 into alliedmodders:master Nov 7, 2020
@JoinedSenses JoinedSenses deleted the patch-1 branch November 7, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Headline Headline Headline approved these changes

@peace-maker peace-maker peace-maker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoinedSenses @peace-maker @Headline