Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SourcePawn JIT metadata config #1412

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Expose SourcePawn JIT metadata config #1412

merged 1 commit into from
Jun 30, 2021

Conversation

asherkin
Copy link
Member

Adds a new option to core.cfg to configure the debug/profiling metadata written by the JIT.

Depends on alliedmodders/sourcepawn#533.

Copy link
Member

@KyleSanderson KyleSanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style is all over the map on this one if you can tighten it up a bit.

@asherkin asherkin marked this pull request as ready for review June 30, 2021 18:05
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine to change the flags during runtime using sm config JITMetadata jitdump?

core/sourcemod.cpp Show resolved Hide resolved
@asherkin
Copy link
Member Author

Is it fine to change the flags during runtime using sm config JITMetadata jitdump?

It isn't going to cause any harm, but it may or may not have any effect depending on the current state of things.

@asherkin asherkin merged commit 77259ac into master Jun 30, 2021
@asherkin asherkin deleted the sourcepawn-perf branch June 30, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants