Allow hexadecimal and octal offsets #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only a professional could mess up a single line commit ._. |
KyleSanderson
approved these changes
Mar 7, 2021
There was a problem hiding this comment.
@psychonic are you okay with this? I haven't seen Paul in ages.
|
Could apply the same patch to the "Addresses" offsets while you're at it! |
|
I'm a little concerned about octal support here, just because of the general soup of issues with the leading-zero prefix - but it's very minor and hex support is far more useful. |
peace-maker
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think swapping atoi for strtol correctly implements this? I haven't really read the sourcemod code before.
For issue #1415