-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues when loading randomcycle from disabled folder #1428
Conversation
So |
If the map changes twice from our data model there can be multiples of these timers running because this isn't killed with fire when the level ends. To fix this one I think we just need TIMER_FLAG_NOMAPCHANGE and nuke the global as it isn't needed and welcomes glitches. There was an ancient issue with OnConfigsExecuted firing multiple times, and that could indeed be the issue here (if you want to step through with a debugger that would be cool). However, I'd suspect there's multiple map plugins loaded at the moment, so the server is changing levels twice (which also happened to me, over 10 years ago). I do believe the current PR resolves the issue, but I don't believe it's the correct fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing this up! Please consider the following change if you have the time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag is in the wrong arg.
currently, when loading randomcycle, it runs
Timer_RandomizeNextmap
twice, leading to odd behavior where the map gets changed twice after timelimit is reached. This fixes that issue by only allowing the timer to be run once per map.