Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fix not working MENU_DEBUG #1506

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Conversation

Wend4r
Copy link
Contributor

@Wend4r Wend4r commented Jun 21, 2021

Fixed a compilation error

error: use of undeclared identifier 'g_Logger'

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right, you can't use an internal header from logic inside core - the extern won't be populated at runtime as it is part of the logic binary instead.

The code needs updating to use the logger global provided by logic_bridge.h (already included here), which'll call over into the correct library.

@Wend4r
Copy link
Contributor Author

Wend4r commented Jun 21, 2021

Works
image

@Wend4r Wend4r requested a review from asherkin June 21, 2021 10:22
Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asherkin asherkin merged commit 267eb90 into alliedmodders:master Jun 21, 2021
@Wend4r Wend4r deleted the patch-2 branch July 10, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants