Fix vprof crashing in some games #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some engines are very sensitive to exactly when in a frame vprof is enabled, the vprof commands use a special command registration method to defer their execution to the start of the next frame. Instead of starting/stopping vprof directly ourselves, use the built-in commands to ensure that the timing is correct and the server does not crash. Fixes #1162
dvander
approved these changes
Jul 18, 2021
psychonic
pushed a commit
that referenced
this pull request
Mar 20, 2022
Some engines are very sensitive to exactly when in a frame vprof is enabled, the vprof commands use a special command registration method to defer their execution to the start of the next frame. Instead of starting/stopping vprof directly ourselves, use the built-in commands to ensure that the timing is correct and the server does not crash. Fixes #1162 (cherry picked from commit f8f5a18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some engines are very sensitive to exactly when in a frame vprof is
enabled, the vprof commands use a special command registration method
to defer their execution to the start of the next frame. Instead of
starting/stopping vprof directly ourselves, use the built-in commands
to ensure that the timing is correct and the server does not crash.
Fixes #1162