-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OnClientLanguageChanged() forward #1597
Conversation
Works for CS:GO on_client_language_loaded_test.zip
|
For consistency, this would need to be implemented for all games (even though it would be called right at connect for non-CS:GO). |
I think this would be best as As with other feature requests / changes, this could do with your use case and an analysis why this is the best and most flexible solution. |
on_client_language_changed_test.zip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @asherkin ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here all looks good to me, I think we just need the forward hooked up in CPlayer::SetLanguageId
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it is there, I'm blind.
This forward is needed so that plugins can perform actions on the player related to his language at
OnClientLanguageLoaded()
moment.