Skip to content

Fix up OnClientSettingsChange logic order. #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

Fix up OnClientSettingsChange logic order. #1605

merged 1 commit into from
Oct 24, 2021

Conversation

@psychonic
Copy link
Member

@psychonic psychonic commented Oct 24, 2021

@psychonic
Fix up OnClientSettingsChange logic order.
f576ef3 
- Fixes bot name cache not getting updated (see #1579)
- Fixes IClientListener::OnClientSettingsChanged not being called for bots.
@psychonic psychonic merged commit 3332da3 into master Oct 24, 2021
@psychonic psychonic deleted the issue-1579 branch October 24, 2021 14:07
@asherkin asherkin added the hacktoberfest-accepted opt-in for hacktoberfest prs label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asherkin asherkin asherkin approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted opt-in for hacktoberfest prs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psychonic @asherkin