Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up gamedata CRC functionality #1621

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Fix up gamedata CRC functionality #1621

merged 2 commits into from
Nov 1, 2021

Conversation

psychonic
Copy link
Member

  • Changes the CRC implementation to match what appears to be most other popular implementations.
  • Fixes server bin name lookup, broken for most engines.

@asherkin
Copy link
Member

asherkin commented Nov 1, 2021

With the CRC impl change, do we want a different gamedata key so we don't break old versions? Or just avoid using it for a few years?

@peace-maker
Copy link
Member

Since this was undocumented ever since, we could just say it's a "new" feature. You're required to update to a newer SourceMod build to use it. It's partially broken due to the hardcoded server.so path on older versions anyway and nobody complained, which seems to be a good indicator, that this isn't used anywhere.

@asherkin
Copy link
Member

asherkin commented Nov 1, 2021

I guess as long as we're always restricting the "old" gamedata rather than the "new" gamedata that does work!

@psychonic
Copy link
Member Author

I guess as long as we're always restricting the "old" gamedata rather than the "new" gamedata that does work!

I think that's the only way we'd plan to use it. That way it's less critical to go back and edit later.

@psychonic psychonic merged commit f229bad into master Nov 1, 2021
@psychonic psychonic deleted the gamedata-crc-fixes branch November 1, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants