Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded a question mark #1699

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Remove hardcoded a question mark #1699

merged 1 commit into from
Feb 3, 2022

Conversation

TheByKotik
Copy link
Contributor

My little arguments:

  1. Hardcoded strings is not a good idea.
  2. In some cases it is really looks amiss (in my language).

peace-maker
peace-maker approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. I've seen many How much is the fish?? votes, where the question already included the questionmark.

@asherkin asherkin merged commit f5461df into alliedmodders:master Feb 3, 2022
@TheByKotik TheByKotik deleted the remove-hardcoded-a-question-mark branch February 3, 2022 12:05
psychonic pushed a commit that referenced this pull request Mar 20, 2022
@TheByKotik @psychonic
Remove hardcoded question mark from sm_vote (#1699)
38bece1 
(cherry picked from commit f5461df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peace-maker peace-maker peace-maker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheByKotik @peace-maker @asherkin