Allow ROOT flag to call public votes #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allow ROOT flag to call votes even if a delay is set. Its nice to have the possibility to set a delay betweens votes to limit public votes. Generally, we do this when we have lots of admins. But as a ROOT flag this limit shall no be set.
This patch allow ROOT flag to call votes even if a delay is set. Its nice to have the possibility to set a delay betweens votes to limit public votes. Generally, we do this when we have lots of admins. But as a ROOT flag this limit shall no be set.
Kenzzer
reviewed
Apr 6, 2022
plugins/basevotes.sp
Outdated
| @@ -406,8 +406,13 @@ void VoteSelect(Menu menu, int param1, int param2 = 0) | |||
|
|
|||
| bool TestVoteDelay(int client) | |||
| { | |||
| if (CheckCommandAccess(client, "sm_vote_access", ADMFLAG_ROOT, true)) | |||
There was a problem hiding this comment.
sm_vote_access seems a bit off as a name, and is probably going to clash with any future changes to vote cmds.
May I recommend sm_vote_delay_bypass, also the default flag for this shouldn't be the admin flag root but cvar, in order to line up with sm's sm_vote_delay convar as any admin with such permission could disable delays anyways. This will still allow root admins to bypass delays regardless.
There was a problem hiding this comment.
Just noticed this is a duplicate of #1730, making a reference to it here so my comment can be relayed on both without having to send it twice.
|
Duplicate of #1730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allow ROOT flag to call votes even if a delay is set. Its nice to have the possibility to set a delay betweens votes to limit public votes. Generally, we do this when we have lots of admins. But as a ROOT flag this limit shall no be set.