-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new method - Converts a bit string to a string of flag characters #377
Conversation
I added new syntax, can someone look for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this is old. Sorry for the really long wait. The interchangeable bits vs AdminFlag vs character representation of admin permissions is ridiculous, but what we have I guess. Since we have natives for lots of the other conversions already this seems like a reasonable addition.
The function name could be a bit more descriptive. I'd suggest FlagBitsToString
?
Yeah I add this very long time ago, but it's ok 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good now except for the usage of tabs for indentation in the doc comment, but this has waited for too long already. Sorry for taking this long and thank you for your patience!
I wrote this method a long time ago, maybe this will be helpful.