-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tf2.inc TFCond enums #474
Update tf2.inc TFCond enums #474
Conversation
|
Thanks. |
|
Well I tried to find the conds before. |
…-update Update tf2.inc TFCond enums
|
To be fair, 108-113 were in pull request #450 which was soft-rejected (because of the other changes I assume) |
|
@powerlord you keep saying we're soft rejecting PRs when they're incomplete. As always, if something is missed, you're absolutely free to message me. However, trolling around in PRs asking why they're soft rejected when they're not functional helps no one. I don't get it. |
|
Wtf |
|
@KyleSanderson The other PR was incomplete? Last I checked, it had all the TFCond, TF_CUSTOM, and TF_WEAPON values that were added to the game prior to the time it was created. No,@asherkin's comment were pretty clear about why it was being soft-rejected: it added secondary names to older TFCond values. On a side note, I rarely comment on PRs, so I'm not sure where the "you keep saying" part is coming from. |
|
@powerlord below is the most obvious one. There's more from yourself on the board. However, like the above comments, this doesn't belong here. |
|
@KyleSanderson please stop picking fights |
|
Out of curiousity, why was this merged when it breaks consistency with the earlier 'Rune' condition names? |
|
Ah really?.... Oh yes I see what you mean, I'm sorry, I didn't paid attention. Perhaps I or you could fix it for me? |
|
It's about 23 days too late for that. |
|
w.r.t. #450 I'll move all the old names up to the top of the list or the bottom of the list and separate them from the FGD/internal names by a few lines, and with that I can also add TFCond_RuneKing/etc matching the other Rune names. I was just wondering why this got merged in the first place without anybody bringing that up. |
I don't know the other conds before, but 114 is for the spawn outline.(added in gun mettle update).